Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #15563 to 7.17: [ci] JDK matrix Buildkite pipelines (pt 2/Windows) #15569

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport PR #15563 to 7.17 branch, original message:


Release notes

[rn:skip]

What does this PR do?

This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels.

testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty fails on Windows Buildkite agents and it's a test issue tracked in #15562.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works:

Linux improved group views (link):

Screenshot

image

image

Windows run (link):

This run demonstrates two failures (Windows 2022 + 2019) due to #15562 , as well a success (Windows 2019).

Screenshot

image

Note that we also collect archived build artifacts to assist with troubleshooting:

Screenshot

image

How to test this PR locally

Just kick off a build using https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline#new and defining this PR i.e. pull/15563/merge in the branch field.

Related issues

This commit adds JDK matrix Buildkite pipelines for
Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows
pipelines) by removing the os-jdk prefix from the job labels.

`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
fails on Windows Buildkite agents and it's a test issue tracked in
#15562.

Relates:

- #15539
- elastic/ingest-dev#1725

(cherry picked from commit 0ede19a)
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@dliappis dliappis merged commit 56812c3 into 7.17 Nov 13, 2023
3 checks passed
@roaksoax roaksoax added the ci label Dec 13, 2023
@jsvd jsvd deleted the backport_15563_7.17 branch March 11, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants